Skip to content

Fix context key collision: agentSessionType and chatSessionType#292590

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/fix-naming-collision-keys
Draft

Fix context key collision: agentSessionType and chatSessionType#292590
Copilot wants to merge 2 commits intomainfrom
copilot/fix-naming-collision-keys

Conversation

Copy link
Contributor

Copilot AI commented Feb 3, 2026 •
edited
Loading

Both ChatContextKeys.chatSessionType and ChatContextKeys.agentSessionType were using the same underlying context key string 'chatSessionType', causing ambiguity in context key resolution.

Changes

Changed agentSessionType to use distinct key string:

// Before
export const agentSessionType = new RawContextKey<string>('chatSessionType', '', ...);

// After  
export const agentSessionType = new RawContextKey<string>('agentSessionType', '', ...);

All usages already reference the context key through the API (.key, .isEqualTo(), .bindTo()), so no consumer changes required.

Original prompt

This section details on the original issue you should resolve

<issue_title>There's a naming collision: both ChatContextKeys.chatSessionType (line 65) and ChatContextKeys.agentSessionType (line 103) use the same context key string 'chatSessionType'. This creates ambiguity and can lead to unexpected behavior. The agentSessionType export should use a different key string, such as 'agentSessionType'.</issue_title>
<issue_description>There's a naming collision: both ChatContextKeys.chatSessionType (line 65) and ChatContextKeys.agentSessionType (line 103) use the same context key string 'chatSessionType'. This creates ambiguity and can lead to unexpected behavior. The agentSessionType export should use a different key string, such as 'agentSessionType'.

	export const chatSessionType = new RawContextKey<string>('sessionType', '', { type: 'string', description: localize('chatSessionType', "The type of the current chat session.") });

Originally posted by @copilot in #288181 (comment)
</issue_description>

Comments on the Issue (you are @copilot in this section)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@osortega
Fix naming collision: change agentSessionType key from 'chatSessionTy…
2540f23 
…pe' to 'agentSessionType'

Co-authored-by: osortega <48293249+osortega@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix naming collision in ChatContextKeys exports Fix context key collision: agentSessionType and chatSessionType Feb 3, 2026
Copilot AI requested a review from osortega February 3, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@osortega osortega Awaiting requested review from osortega

At least 1 approving review is required to merge this pull request.

Assignees

@osortega osortega

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@osortega